Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implements the project list #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

janitha09
Copy link

This change implements project list endpoint

@noam-codefresh
Copy link

Hello @janitha09 - I apologize for letting this PR fall between the cracks. We would be happy to merge it into the master branch. Can you please merge/rebase it, and we will have a look again?

@noam-codefresh noam-codefresh self-assigned this Aug 17, 2021
@janitha09 janitha09 force-pushed the master branch 2 times, most recently from 384d395 to ad99aea Compare August 17, 2021 19:27
@janitha09
Copy link
Author

@noam-codefresh merge conflicts and API changes have been resolved for

Comment on lines +1 to +3
{
"go.testFlags": ["-v"]
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do not include this file in the pr
I see the repo doesn't have a .gitignore file - maybe even include one that ignores visual studio code and golang artifacts? (just a suggestion)


func TestProject(t *testing.T) {

cf := New(&clientOptions)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you can use the codefresh/mock/codefresh struct to make this test better?
you will also need to regenerate the mock itself to include your Projects() func. You will need mockery 1.1.1 installed, and run go generate ./... for it.
let me know if you need any help with it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noam-codefresh is there an example that shows the coddfresh mock structs use.

For an API client that should have been code generated, this abstraction is proving to be rather tedious, and hard to follow, it most certainly confuses the compiler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants